Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Kedro-Airflow plugin docstring from appearing in kedro -h #118

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Keep Kedro-Airflow plugin docstring from appearing in kedro -h #118

merged 2 commits into from
Feb 21, 2023

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Feb 17, 2023 •
edited by noklam
Loading

Description

See
kedro-org/kedro#1749

As plugin docstring end up showing in the kedro CLI, the easier solution is to remove the docstring.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@deepyaman deepyaman mentioned this pull request Feb 17, 2023
Closed
@merelcht merelcht requested a review from noklam February 21, 2023 16:57
@merelcht merelcht merged commit d31425a into main Feb 21, 2023
@merelcht merelcht deleted the deepyaman-patch-1 branch February 21, 2023 17:05
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 13, 2023
@deepyaman @dannyrfar
Keep Kedro-Airflow plugin docstring from appearing in kedro -h (ked…
92fed6d 
…ro-org#118)

Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Keep Kedro-Airflow plugin docstring from appearing in kedro -h (ked…
83a4591 
…ro-org#118)

Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Keep Kedro-Airflow plugin docstring from appearing in kedro -h (ked…
f4fbe89 
…ro-org#118)

Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Keep Kedro-Airflow plugin docstring from appearing in kedro -h (ked…
cd3b6f3 
…ro-org#118)

Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@noklam noklam noklam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @noklam @merelcht