Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bandit checks by adding timeout to requests.post() calls #133

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix bandit checks by adding timeout to requests.post() calls #133

merged 1 commit into from
Mar 20, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Mar 20, 2023 •
edited
Loading

Description

Bandit security checks were failing with bandit 1.7.5

Development notes

Adding timeout to requests.post() calls fixed it. I ran the checks locally to verify.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@merelcht
Fix bandit check by adding timeout to requests.post calls
17a22b7 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Mar 20, 2023
noklam
noklam approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for fixing this ⭐️

AhdraMeraliQB
AhdraMeraliQB approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@merelcht merelcht merged commit 81202a5 into main Mar 20, 2023
@merelcht merelcht deleted the fix/bandit-check branch March 20, 2023 15:13
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@merelcht @dannyrfar
Fix bandit check by adding timeout to requests.post calls (kedro-org#133
eebc796 
)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@merelcht @dannyrfar
Fix bandit check by adding timeout to requests.post calls (kedro-org#133
b84a223 
)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@merelcht @dannyrfar
Fix bandit check by adding timeout to requests.post calls (kedro-org#133
cdb563f 
)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@noklam noklam noklam approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @noklam @AhdraMeraliQB