-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polars Generic Dataset #153
Conversation
Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
…test-reqs dep hell Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
…t to parqquet from csv Signed-off-by: wmoreiraa <walber3@gmail.com>
…anch Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
Signed-off-by: wmoreiraa <walber3@gmail.com>
New branch
Signed-off-by: wmoreiraa <walber3@gmail.com>
Notes: the comments/review from @merelcht on #116 are on point and were not addressed (those not related to spark changes that are not on this PR anymore). "Maybe I'm misunderstanding this, but if you're using a read-only data format, you simply shouldn't call save right? It kind of sounds that if you change the write mode to ignore you wouldn't get an error, but you would get raise DataSetError(f"Write mode '{self._write_mode}' is read-only.") as set in line 219." . I think this one could go two different ways:
@datajoely @astrojuanlu , I might not have any time soon to do this. Think you could finish this fix? @merelcht all other review/comments are addressed if removing the write_mode, this is why I dont specifically copied here. Also, thank you for the review. |
Thanks a lot for getting this far @wmoreiraa. We'll take care of the final push 💪🏽 |
Closing in favor of gh-170. |
Signed-off-by: wmoreiraa walber3@gmail.com
Description
Add
polars.GenericDataSet
as discussed in #95Ive probably closed the old PR doing wrong git things #116
Development notes
Similar to
pandas.GenericDataSet
, changes made:Checklist
RELEASE.md
file