Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(docker): remove outdated logging-related step #207

Merged
merged 3 commits into from
May 17, 2023
Merged

test(docker): remove outdated logging-related step #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42c166c
fixkedro- docker e2e test
noklam May 17, 2023
a42b947
fix: add timeout to request to satisfy bandit lint
deepyaman May 17, 2023
7377c67
Merge branch 'main' into fix/kedro_docker_e2e
deepyaman May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion kedro-docker/features/docker.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Docker commands in new projects
Background:
Given I have prepared a config file
And I run a non-interactive kedro new using pandas-iris starter
And I have fixed logs write permission
And I have installed the project dependencies
And I have removed old docker image of test project

Expand Down
1 change: 0 additions & 1 deletion kedro-docker/features/docker_with_spark.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Docker commands in new Spark projects
Background:
Given I have prepared a config file
And I run a non-interactive kedro new using pyspark-iris starter
And I have fixed logs write permission
And I have installed the project dependencies
And I have removed old docker image of test project

Expand Down
15 changes: 0 additions & 15 deletions kedro-docker/features/steps/cli_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,21 +126,6 @@ def create_configuration_file(context):
yaml.dump(config, config_file, default_flow_style=False)


@given("I have fixed logs write permission")
def modify_write_permission(context):
"""
Kedro-docker mounts some subdirectories the current directory (like logs, notebooks etc)
into the Docker container.
If you run kedro commands with different users,
they might create files and directories not writable by each other.
So we are fixing the permissions here.
"""
(context.root_project_dir / "logs").chmod(0o777)
journal_dir = context.root_project_dir / "logs" / "journals"
journal_dir.mkdir(parents=True, exist_ok=True)
journal_dir.chmod(0o777)


@given("I run a non-interactive kedro new using {starter_name} starter")
def create_project_from_config_file(context, starter_name):
"""Behave step to run kedro new
Expand Down