fix(datasets): Add optional dependencies duplication in pyproject.toml #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
astrojuanlu
reviewed
Aug 16, 2023
There was a problem hiding this comment.
I'm OK with this approach as long as we are fine with keeping the new extras we're introducing in the long run. In other words: at some point in the future, we settle with the new syntax and tell our users to do pip install kedro-datasets[pandas-csvdataset]. See more context in my comment here #306 (comment)
|
Closed in favor of #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves as an interim solution to the issue of nesting with "." in the pyproject.toml file. All lines have been duplicated following this pattern:
It appears the long-term solution might involve aligning names with the packaging standards, as mentioned by @astrojuanlu in this comment, or transitioning from setuptools to poetry.
Development notes
Manually tested: works well with .[all] and .[spark.SparkDataSet].
It seems we should introduce tests to automate the verification of dependency installations.
Checklist
RELEASE.mdfile