-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): Add 3.11 support to kedro-docker #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhdraMeraliQB
changed the title
ci: Add 3.11 support to all plugins
ci: Add 3.11 support to all kedro-airflow and kedro-docker
Sep 5, 2023
AhdraMeraliQB
force-pushed
the
ci/add-311-support
branch
from
September 5, 2023 14:41
28197ad
to
aa31174
Compare
astrojuanlu
reviewed
Sep 7, 2023
AhdraMeraliQB
changed the title
ci: Add 3.11 support to all kedro-airflow and kedro-docker
ci: Add 3.11 support to kedro-docker
Sep 7, 2023
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit fd99930. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
force-pushed
the
ci/add-311-support
branch
from
September 7, 2023 14:12
f2916c7
to
adc4d95
Compare
AhdraMeraliQB
changed the title
ci: Add 3.11 support to kedro-docker
build(docker): Add 3.11 support to kedro-docker
Sep 7, 2023
SajidAlamQB
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🌟 @AhdraMeraliQB, these builds take a really long time thank you!
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
merelcht
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on getting this working! ⭐
4 tasks
sbrugman
pushed a commit
to sbrugman/kedro-plugins
that referenced
this pull request
Sep 11, 2023
* Add 3.11 to version matrices Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Comment out plugins not of focus Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Drop Python upper bound Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Unpin precommit Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Bump pre-commit hook version Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Drop Python upper bound" This reverts commit fd99930. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert lint version Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try unpin docker Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix typo Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try upgrade pip Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Undo prev commit Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Temp change for faster CI Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try something Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try something else Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Include 3.11 in pyproject.toml Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change python version on docker Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove bandit pin airflow Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try unpinned bandit Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Restore other files Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Restore other files pt 2 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add changes to RELEASE.md Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Apply suggestions from code review Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> --------- Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial solution for #265
Development notes
Checklist
RELEASE.md
file