Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): Add 3.11 support to kedro-docker #329

Merged
merged 23 commits into from
Sep 7, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Sep 5, 2023

Description

Partial solution for #265

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@AhdraMeraliQB AhdraMeraliQB changed the title ci: Add 3.11 support to all plugins ci: Add 3.11 support to all kedro-airflow and kedro-docker Sep 5, 2023
@AhdraMeraliQB AhdraMeraliQB changed the title ci: Add 3.11 support to all kedro-airflow and kedro-docker ci: Add 3.11 support to kedro-docker Sep 7, 2023
Ahdra Merali added 22 commits September 7, 2023 15:12
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit fd99930.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB changed the title ci: Add 3.11 support to kedro-docker build(docker): Add 3.11 support to kedro-docker Sep 7, 2023
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review September 7, 2023 14:35
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🌟 @AhdraMeraliQB, these builds take a really long time thank you!

.github/workflows/kedro-docker.yml Outdated Show resolved Hide resolved
.github/workflows/kedro-docker.yml Outdated Show resolved Hide resolved
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
@AhdraMeraliQB AhdraMeraliQB enabled auto-merge (squash) September 7, 2023 15:09
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on getting this working! ⭐

@AhdraMeraliQB AhdraMeraliQB merged commit e4ea7c6 into main Sep 7, 2023
53 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the ci/add-311-support branch September 7, 2023 15:36
sbrugman pushed a commit to sbrugman/kedro-plugins that referenced this pull request Sep 11, 2023
* Add 3.11 to version matrices

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Comment out plugins not of focus

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Drop Python upper bound

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Unpin precommit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Bump pre-commit hook version

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Drop Python upper bound"

This reverts commit fd99930.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert lint version

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try unpin docker

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Fix typo

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try upgrade pip

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Undo prev commit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Temp change for faster CI

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try something

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try something else

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Include 3.11 in pyproject.toml

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Lint

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change python version on docker

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove bandit pin airflow

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try unpinned bandit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Restore other files

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Restore other files pt 2

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add changes to RELEASE.md

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Apply suggestions from code review

Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>

---------

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants