build(telemetry): Add python 3.11 to telemetry #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
force-pushed
the
3.11-telemetry
branch
from
3f808ef
to
6502dfc
Compare
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
requested review from
SajidAlamQB,
astrojuanlu,
merelcht and
AhdraMeraliQB
AhdraMeraliQB
approved these changes
Sep 5, 2023
merelcht
reviewed
Sep 5, 2023
Comment on lines
+71
to
+74
| mocker.patch( | ||
| "kedro.framework.cli.cli.importlib.import_module", | ||
| return_value=Module(cli=cli), | ||
| ) |
There was a problem hiding this comment.
What is different in python 3.11 that required moving this down?
There was a problem hiding this comment.
This fix from the 3.11 PR on kedro seemed to fix the failing tests. @SajidAlamQB do you know more about this?
There was a problem hiding this comment.
I believe it was because it would makes all subsequent mocker.patch fail this could be because of a change in how unittest.mock or importlib work python 3.11. @noklam do you have any other thoughts on it?
merelcht
approved these changes
Sep 7, 2023
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
4 tasks
sbrugman
pushed a commit
to sbrugman/kedro-plugins
that referenced
this pull request
Sep 11, 2023
* Add 3.11 to telemetry Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Remove extra lint tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add changes to RELEASE.md Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial solution for #265
Development notes
NOTE: linter's still running on python 3.8 because of some
pre-commiterrors. To be done as a follow up for all plugins. #331Checklist
RELEASE.mdfile