Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(datasets): add type targets for return types #797

Merged
merged 32 commits into from
Aug 2, 2024
Merged

build(datasets): add type targets for return types #797

merged 32 commits into from
Aug 2, 2024

Conversation

deepyaman
Copy link
Member

Description

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@deepyaman deepyaman force-pushed the feat/datasets/expose-load-and-save branch 8 times, most recently from 06c04fc to d6213c6 Compare August 1, 2024 19:09
This was referenced Aug 1, 2024
Merged
Merged
@deepyaman deepyaman force-pushed the feat/datasets/expose-load-and-save branch 5 times, most recently from 01c5d4b to 6ee855e Compare August 2, 2024 05:05
@deepyaman
build(datasets): circumvent Requests ref not found
f07085a 
See also: sphinx-doc/sphinx#9653

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): circumvent dask_expr ref not found
97d1ee5 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add VersionNotFoundError exc type
10d93c7 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
docs(datasets): update malformed dataset docstring
d5342b8 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
6cf3b95 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
f3cd239 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
3dbfc43 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing transformers.Pipeline
1a28335 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): create new ir.Table type target
810e761 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add a numpy.ndarray type target
33e1556 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add type target for plt.Figures
4d05ff4 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): create NetworkX Graph type target
aceee60 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
3f53182 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add PIL.Image.Image type target
67d9147 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add type target for Plotly Figure
8e11de2 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
95821ae 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing LazyFrame type target
4c431a0 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
aa53fb5 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing target for DeltaTable
7a4c83c 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing DataFrame type target
ee2272b 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): create type target for csr_matrix
392779e 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add type target for Keras Model
916ac5f 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add missing type target for video
9968ad3 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): make type_targets for Anthropic
699000b 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add type target for Cohere models
10e4013 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add xarray dataset type_targets
4a41d4f 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
build(datasets): add target for xarray DataArray
10868a1 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
feat(datasets)!: expose load and save publicly
1733e4d 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
fix(datasets): replace calls to _meth with wrapped
42201cf 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
fix(datasets): pass self for __wrapped__ calls
3204803 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
revert(datasets): restore to _loads and _saves
e965286 
Refs: 3204803, 42201cf, b40597c

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman force-pushed the feat/datasets/expose-load-and-save branch from 6ee855e to e965286 Compare August 2, 2024 05:35
@deepyaman deepyaman changed the title feat(datasets)!: expose load and save publicly build(datasets): add type targets for return types Aug 2, 2024
@deepyaman deepyaman marked this pull request as ready for review August 2, 2024 05:46
@ElenaKhaustova ElenaKhaustova merged commit 95219ad into main Aug 2, 2024
15 checks passed
@ElenaKhaustova ElenaKhaustova deleted the feat/datasets/expose-load-and-save branch August 2, 2024 08:06
@deepyaman deepyaman mentioned this pull request Aug 2, 2024
Draft
4 tasks
merelcht pushed a commit to galenseilis/kedro-plugins that referenced this pull request Aug 27, 2024
@deepyaman @merelcht
build(datasets): add type targets for return types (kedro-org#797)
2a344c8 
* build(datasets): circumvent Requests ref not found

See also: sphinx-doc/sphinx#9653

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): circumvent dask_expr ref not found

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add VersionNotFoundError exc type

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* docs(datasets): update malformed dataset docstring

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing transformers.Pipeline

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): create new `ir.Table` type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add a `numpy.ndarray` type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add type target for `plt.Figure`s

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): create NetworkX Graph type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add `PIL.Image.Image` type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add type target for Plotly Figure

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add type target for Figure Widget

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing LazyFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing target for DeltaTable

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing DataFrame type target

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): create type target for csr_matrix

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add type target for Keras `Model`

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add missing type target for video

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): make `type_targets` for Anthropic

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add type target for Cohere models

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add xarray dataset `type_targets`

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* build(datasets): add target for xarray `DataArray`

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* feat(datasets)!: expose `load` and `save` publicly

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* fix(datasets): replace calls to _meth with wrapped

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* fix(datasets): pass `self` for `__wrapped__` calls

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* revert(datasets): restore to `_load`s and `_save`s

Refs: 3204803, 42201cf, b40597c

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

---------

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankatiyar ankatiyar ankatiyar approved these changes

@ElenaKhaustova ElenaKhaustova ElenaKhaustova approved these changes

@noklam noklam Awaiting requested review from noklam

@merelcht merelcht Awaiting requested review from merelcht

@lrcouto lrcouto Awaiting requested review from lrcouto

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @ankatiyar @ElenaKhaustova