Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): Add GoogleSheetsDataset #810

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lvijnck
Copy link

@lvijnck lvijnck commented Aug 20, 2024

Description

Enable reading/writing to Sheets

Development notes

Add Google SheetsDataset

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@@ -1,6 +1,8 @@
# Upcoming Release
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. Whats wrong with the pre-commit hooks in this repo? Seems all files have something going on.

Copy link
Contributor

@DimedS DimedS Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix it in separate PR, I will do it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to replicate the issue with pre-commit. Could you let me know how you're running pre-commit, because for me it wasn't generate so many changes in different files when trying to commit this dataset? You can also remove that commit and continue without it: 06a5439

@DimedS
Copy link
Contributor

DimedS commented Aug 21, 2024

@lvijnck, could you please sign off on the commits according to the guidelines provided in this manual: https://github.com/kedro-org/kedro-plugins/pull/810/checks?check_run_id=29048896619

@DimedS DimedS changed the title Add GoogleSheetsDataset feat(datasets): Add GoogleSheetsDataset Aug 21, 2024
@ankatiyar
Copy link
Contributor

Hi @lvijnck, I see that this PR has been inactive for a bit. It would be nice to get this in, would you be able to fix the sign-offs on the commits and revert changes to other files?

@merelcht
Copy link
Member

Hi @lvijnck , this PR has converged a lot from the main branch now. Are you still interested in completing it? If so, it might be easier to recreate it against the up to date main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants