-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets): Add GoogleSheetsDataset #810
base: main
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,8 @@ | |||
# Upcoming Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. Whats wrong with the pre-commit hooks in this repo? Seems all files have something going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix it in separate PR, I will do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to replicate the issue with pre-commit. Could you let me know how you're running pre-commit, because for me it wasn't generate so many changes in different files when trying to commit this dataset? You can also remove that commit and continue without it: 06a5439
@lvijnck, could you please sign off on the commits according to the guidelines provided in this manual: https://github.com/kedro-org/kedro-plugins/pull/810/checks?check_run_id=29048896619 |
Hi @lvijnck, I see that this PR has been inactive for a bit. It would be nice to get this in, would you be able to fix the sign-offs on the commits and revert changes to other files? |
Hi @lvijnck , this PR has converged a lot from the |
Description
Enable reading/writing to Sheets
Development notes
Add Google SheetsDataset
Checklist
RELEASE.md
file