feat(datasets): add wrapped dataset to store the response from a POST/PUT request #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npfp
commented
Oct 23, 2024
| @property | ||
| def _nested_dataset_type( | ||
| self, | ||
| ) -> Type[JSONDataset | PickleDataset | MemoryDataset]: |
There was a problem hiding this comment.
There might be a better way to do this.
npfp
commented
Oct 23, 2024
Comment on lines
+243
to
+250
| if self._extension == "json": | ||
| self.wrapped_dataset.save(response.json()) #TODO(npfp): expose json loads arguments | ||
| elif self._extension == "text": | ||
| self.wrapped_dataset.save(response.text) | ||
| elif self._extension: | ||
| self.wrapped_dataset.save(response) |
There was a problem hiding this comment.
Might be better to check on the self.wrapped_dataset type:
Suggested change
| if self._extension == "json": | |
| self.wrapped_dataset.save(response.json()) #TODO(npfp): expose json loads arguments | |
| elif self._extension == "text": | |
| self.wrapped_dataset.save(response.text) | |
| elif self._extension: | |
| self.wrapped_dataset.save(response) | |
| elif isinstance(self.wrapped_dataset, JSONDataset): | |
| self.wrapped_dataset.save(response.json()) #TODO(npfp): expose json loads arguments | |
| elif isinstance(self.wrapped_dataset, TextDataset) | |
| self.wrapped_dataset.save(response.text) | |
| elif self._extension: | |
| self.wrapped_dataset.save(response) |
npfp
force-pushed
the
feature/save-response-in-api-dataset
branch
from
2978b3c to
dc433d1
Compare
npfp
changed the title
npfp
changed the title
…/PUT request Proof of concept to start discussions about design on how to store and use response. Signed-off-by: Nicolas Perrin <1208895+npfp@users.noreply.github.com>
npfp
force-pushed
the
feature/save-response-in-api-dataset
branch
from
dc433d1 to
e9980af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to start discussions about design on how to store and use the
responseobject.Description
To pursue discussions on how we could store the
responseobject from aPOSTorPUTapi request.Relates to #748
Development notes
Checklist
RELEASE.mdfile