Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings.py #133

Merged
merged 2 commits into from
May 31, 2023
Merged

Update settings.py #133

merged 2 commits into from
May 31, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented May 31, 2023

Motivation and Context

Do the same as kedro-org/kedro#2587

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

noklam added 2 commits May 26, 2023 16:28
@noklam
Update logging to use kedro.logging.RichHandler
d1f9010 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Update Settings.py
4c15730 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam noklam requested review from astrojuanlu and merelcht May 31, 2023 13:35
@noklam noklam mentioned this pull request May 31, 2023
Merged
10 tasks
merelcht
merelcht approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noklam noklam merged commit eaa66d0 into main May 31, 2023
@noklam noklam deleted the update-settings branch May 31, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@ankatiyar ankatiyar ankatiyar approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noklam @merelcht @ankatiyar