Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests folder to be aligned with develop template #170

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Oct 25, 2023

Motivation and Context

Related to: kedro-org/kedro#2975

The tests directory was moved from {{ cookiecutter.repo_name }}/src/tests to {{ cookiecutter.repo_name }}/tests for templates in the develop branch of kedro framework, kedro-org/kedro#2926. We need to keep the same structure for starters in general as well as so that the add-ons scripts that use starters can work.

Development Notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB SajidAlamQB changed the title Move starters tests folder to be aligned with develop template Move tests folder to be aligned with develop template Oct 25, 2023
@SajidAlamQB SajidAlamQB self-assigned this Oct 25, 2023
@SajidAlamQB SajidAlamQB marked this pull request as ready for review October 25, 2023 14:07
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Copy link
Member

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @SajidAlamQB

@SajidAlamQB SajidAlamQB enabled auto-merge (squash) October 25, 2023 14:45
@SajidAlamQB SajidAlamQB merged commit 542cd26 into main Oct 25, 2023
1 check passed
@SajidAlamQB SajidAlamQB deleted the move-test-and-update-post_gen branch October 25, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants