Skip to content

Commit

Permalink
Testing Path Fix (#1853)
Browse files Browse the repository at this point in the history
* testing windows build

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* testing windows build

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* test circleci

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* testing path

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* testing path

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* testing system independent casting

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* revert test

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* test purepath

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* test purepath

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* revert purepath test

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

---------

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
  • Loading branch information
ravi-kumar-pilla authored Apr 15, 2024
1 parent 21c54f5 commit ecf143c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions package/kedro_viz/integrations/kedro/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import json
import logging
from collections import defaultdict
from pathlib import Path
from pathlib import PurePosixPath
from typing import Any, Union

from kedro.framework.hooks import hook_impl
Expand Down Expand Up @@ -135,7 +135,9 @@ def get_file_size(self, dataset: Any) -> Union[int, None]:
return None

try:
file_path = get_filepath_str(Path(dataset._filepath), dataset._protocol)
file_path = get_filepath_str(
PurePosixPath(dataset._filepath), dataset._protocol
)
return dataset._fs.size(file_path)

except Exception as exc:
Expand Down

0 comments on commit ecf143c

Please sign in to comment.