Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-error-overlay to 6.0.9 #1058

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Sep 12, 2022

Signed-off-by: huongg huongg1409@gmail.com

Description

With the recent update to node v16, there was an error in the console whenever we update any styling

VM10787:2 Uncaught ReferenceError: process is not defined
    at 4043 (<anonymous>:2:13168)
    at r (<anonymous>:2:306599)
    at 8048 (<anonymous>:2:9496)
    at r (<anonymous>:2:306599)
    at 8641 (<anonymous>:2:1379)
    at r (<anonymous>:2:306599)
    at <anonymous>:2:315627
    at <anonymous>:2:324225
    at <anonymous>:2:324229
    at e.onload (index.js:1:1)

The fix for it to update react-error-overlay to 6.0.9

Development notes

Please run npm install when you test this branch, then update any style to see if it updates on the viz automatically and ensure there are no error either in the terminal or in the console

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: huongg <huongg1409@gmail.com>
@tynandebold tynandebold changed the title update react-error-overlay to 6.0.9 Update react-error-overlay to 6.0.9 Sep 12, 2022
…x/update-react-error-overlay

Signed-off-by: Tynan DeBold <thdebold@gmail.com>
Signed-off-by: Tynan DeBold <thdebold@gmail.com>
@tynandebold
Copy link
Member

tynandebold commented Sep 15, 2022

Seems to be fixed now following the steps in this comment (some of the steps).

Signed-off-by: Tynan DeBold <thdebold@gmail.com>
Signed-off-by: Tynan DeBold <thdebold@gmail.com>
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Note
You may have to explicitly install this package for the error to go away, like so: npm install react-error-overlay@6.0.9

@tynandebold tynandebold merged commit df03bd6 into main Sep 15, 2022
@tynandebold tynandebold deleted the fix/update-react-error-overlay branch September 15, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants