Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.7 #1660

Merged
merged 5 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .circleci/continue_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,11 @@ workflows:
- e2e_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- win_e2e_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
filters:
branches:
only:
Expand All @@ -354,11 +354,11 @@ workflows:
- unit_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- win_unit_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
filters:
branches:
only:
Expand All @@ -367,7 +367,7 @@ workflows:
- lint:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- all_circleci_checks_succeeded:
requires:
- e2e_tests
Expand All @@ -393,21 +393,21 @@ workflows:
- e2e_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- win_e2e_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- unit_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- win_unit_tests:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- lint:
matrix:
parameters:
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python_version: ['3.8', '3.9', '3.10', '3.11']
- javascript_lint_and_tests
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Working on your first pull request? You can learn how from these resources:

- Aim for cross-platform compatibility on Windows, macOS and Linux, and support recent versions of major browsers
- We use [SemVer](https://semver.org/) for versioning
- Our code is designed to be compatible with Python 3.7 onwards
- Our code is designed to be compatible with Python 3.8 onwards
- We use [Anaconda](https://www.anaconda.com/distribution/) as a preferred virtual environment
- We use [PEP 8 conventions](https://www.python.org/dev/peps/pep-0008/) for all Python code
- We use [Google docstrings](https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings) for code comments
Expand Down Expand Up @@ -174,7 +174,7 @@ Finally, you can use pseudo-random data, which is procedurally-generated on page

> **Note**: Kedro-Viz>=3.8.0 will not work with projects created with Kedro<=0.16.6. Please consider migrating your project to Kedro>=0.17.0 before you develop against the latest version of Kedro-Viz.

Before launching a development server with a real Kedro project, you'd need to have [Python](https://www.python.org/)(>=3.7, <3.11) installed. We strongly recommend setting up [conda](https://docs.conda.io/en/latest/) to manage your Python versions and virtual environments. You can visit Kedro's [guide to installing conda](https://kedro.readthedocs.io/en/latest/02_get_started/01_prerequisites.html#conda) for more information.
Before launching a development server with a real Kedro project, you'd need to have [Python](https://www.python.org/)(>=3.8) installed. We strongly recommend setting up [conda](https://docs.conda.io/en/latest/) to manage your Python versions and virtual environments. You can visit Kedro's [guide to installing conda](https://docs.kedro.org/en/latest/get_started/install.html#create-a-virtual-environment-for-your-kedro-project) for more information.

The Kedro-Viz repository comes with an example project in the `demo-project` folder. This is used on the [public demo](https://demo.kedro.org/). To use it in your development environment, you need to install both the Kedro-Viz dependencies and a minimal set of dependencies for the demo project:

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Live Demo: <a href="https://demo.kedro.org/" target="_blank">https://demo.kedro.

[![CircleCI](https://circleci.com/gh/kedro-org/kedro-viz/tree/main.svg?style=shield)](https://circleci.com/gh/kedro-org/kedro-viz/tree/main)
[![Documentation](https://readthedocs.org/projects/kedro/badge/?version=stable)](https://docs.kedro.org/en/stable/visualisation/)
[![Python Version](https://img.shields.io/badge/python-3.7%20%7C%203.8%20%7C%203.9%20%7C%203.10-orange.svg)](https://pypi.org/project/kedro-viz/)
[![Python Version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11-orange.svg)](https://pypi.org/project/kedro-viz/)
[![PyPI version](https://img.shields.io/pypi/v/kedro-viz.svg?color=yellow)](https://pypi.org/project/kedro-viz/)
[![Downloads](https://static.pepy.tech/badge/kedro-viz/week)](https://pepy.tech/project/kedro-viz)
[![npm version](https://img.shields.io/npm/v/@quantumblack/kedro-viz.svg?color=cc3534)](https://badge.fury.io/js/%40quantumblack%2Fkedro-viz)
Expand Down
4 changes: 4 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Please follow the established format:

- Display hosted URL in CLI while launching kedro viz. (#1644)

## Bug fixes and other changes

- Remove support for Python 3.7 (#1660)

# Release 6.7.0

## Bug fixes and other changes
Expand Down
5 changes: 0 additions & 5 deletions package/features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ def before_scenario(context, scenario):

kedro_version = None

if sys.version_info < (3, 8) and sys.platform.startswith("win"):
if "lower-bound" in scenario.name:
print(f"{scenario} will be skipped on Windows with Python 3.7")
scenario.skip()

for step in scenario.steps:
if "I have installed kedro version" in step.name:
match = re.search(r"\b\d+\.\d+\.\d+\b", step.name)
Expand Down
3 changes: 1 addition & 2 deletions package/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
packaging~=23.0
kedro>=0.17.5
ipython>=7.0.0, <9.0
fastapi>=0.73.0,<0.200.0; python_version >= '3.8'
fastapi>=0.73.0,<0.104.0; python_version < '3.8'
fastapi>=0.73.0,<0.200.0
pydantic<2
fsspec>=2021.4, <2024.1
s3fs>=2021.4, <2024.1
Expand Down
2 changes: 1 addition & 1 deletion package/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
long_description_content_type="text/markdown",
license="Apache Software License (Apache 2.0)",
url="https://github.com/kedro-org/kedro-viz",
python_requires=">=3.7",
python_requires=">=3.8",
install_requires=requires,
keywords="pipelines, machine learning, data pipelines, data science, data engineering, visualisation",
author="Kedro",
Expand Down
6 changes: 2 additions & 4 deletions package/test_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ matplotlib~=3.5
mypy~=1.0
moto~=4.1.14
psutil==5.9.6 # same as Kedro for now
pylint~=2.17; python_version < '3.8'
pylint~=3.0; python_version >= '3.8'
pylint-pydantic~=0.2.4; python_version < '3.8'
pylint-pydantic>=0.3.0; python_version >= '3.8'
pylint~=3.0
pylint-pydantic>=0.3.0
pytest~=7.4
pytest-asyncio~=0.21
pytest-mock~=3.11
Expand Down