Migrate Viz to use Pydantic V2 #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
|
It's happeninggggggggg |
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
ravi-kumar-pilla
requested review from
tynandebold,
yetudada and
rashidakanchwala
as code owners
ravi-kumar-pilla
requested review from
astrojuanlu,
DimedS,
merelcht and
NeroOkwa
and removed request for
merelcht
|
Fantastic!! |
package/requirements.txt
Outdated
| @@ -2,7 +2,7 @@ packaging~=23.0 | |||
| kedro>=0.18.0 | |||
| ipython>=7.0.0, <9.0 | |||
| fastapi>=0.73.0,<0.200.0 | |||
| pydantic<2 | |||
| pydantic>=2 | |||
There was a problem hiding this comment.
Do we need to put this, or should we just bump the minimum version of fastAPI ?
…irements Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
noklam
reviewed
Feb 20, 2024
| @@ -13,4 +13,3 @@ strawberry-graphql==0.192.0 | |||
| networkx==2.5 | |||
| orjson==3.9 | |||
| secure==0.3.0 | |||
| pydantic==1.10 | |||
There was a problem hiding this comment.
This seems different from the discussion in #1603. Just to confirm, we are dropping Pydantic v1 support altogether now.
There was a problem hiding this comment.
yes we are dropping support for pydantic v1 as there are issues with the v1 api mentioned here and an open PR - https://github.com/tiangolo/fastapi/pull/10223/files
DimedS
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thank you for the PR, @ravi-kumar-pilla . LGTM! Let's move on to v2! 🎉 🎉
rashidakanchwala
approved these changes
Feb 21, 2024
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1603
Development notes
bump-pydantictool@validatorsto@field_validatorsQA notes
kedro viz runshould work as expectedNote: Observed flowchart node arrangements change (mirrored) due to the migration, though the data remains un-affected as below -
Before Migration:
After Migration:
Checklist
RELEASE.mdfile