Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility/Support Matrix Update #1774

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Feb 29, 2024

Description

Resolves #1758

Development notes

  • Updated README docs based on pypi versions

QA notes

  • Users should be able to upgrade the package versions to the last supported version mentioned in README section and find it compatible
  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review February 29, 2024 18:02
README.md Outdated
</tr>
<tr>
<td>>= 3.9</td>
<td>Active</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused by Active. Should we say Current ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a support matrix which suggests we have active support, so I named Active. But I am also not sure if we should remove the compatibility matrix we had earlier. Any suggestions on this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename to Current as well, I do not have a strong opinion on keeping it as Active

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because they are all versions in the matrix, when it says 'Active' it doesn't hit me immediately what is 'Active' versions but I know what 'Current' version is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but otherwise I am fine :) thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed Active to Latest. thanks 👍

@rashidakanchwala rashidakanchwala self-requested a review March 4, 2024 16:38
@rashidakanchwala
Copy link
Contributor

Thanks @ravi-kumar-pilla , this matrix is definitely way more clearer and with the breaking changes we had recently. I think it's best way to showcase.

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ravi-kumar-pilla!

@ravi-kumar-pilla ravi-kumar-pilla merged commit b6b1003 into main Mar 5, 2024
5 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the docs/compatibility-matrix branch March 5, 2024 15:59
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Mar 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Compatibility Matrix
3 participants