Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove demo data source and update feature hints #1804

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Remove demo data source and update feature hints #1804

merged 6 commits into from
Mar 21, 2024
+6 −10

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Mar 14, 2024 •
edited
Loading

Description

  1. This removes the un-used demo source when the host is kedro-org.github.io. This is needed for the GitHub action to point the data source to be gh-pages/workflow artifacts.
  2. Update feature hints

Development notes

  • Remove demo data source and update feature hints.

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
remove demo source
fec38de 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
add release note
193a998 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note and update feature hint links
69a9a33 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Remove demo data source Remove demo data source and update feature hints Mar 14, 2024
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review March 14, 2024 21:14
rashidakanchwala
rashidakanchwala approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :) Good spot on feature hints.

@ravi-kumar-pilla
Merge branch 'main' into fix/viz-build-page
7043f93
@ravi-kumar-pilla
merge main
56b38ed 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'fix/viz-build-page' of https://github.com/kedro-org/ked…
cd68df8 
…ro-viz into fix/viz-build-page

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla merged commit 6206e43 into main Mar 21, 2024
14 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/viz-build-page branch March 21, 2024 21:07
@jitu5 jitu5 mentioned this pull request Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@NeroOkwa NeroOkwa NeroOkwa approved these changes

@jitu5 jitu5 Awaiting requested review from jitu5 jitu5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-kumar-pilla @rashidakanchwala @NeroOkwa