-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown support for version reminders #1826
Conversation
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering that, given the simplicity of our markdown needs—primarily replacing backticks with code-blocks —we could directly use < code > tags for any backticks we encounter. This approach would eliminate the need for any additional dependencies. What do you think?
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
…edro-org/kedro-viz into feat/reminder-markdown-support Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
That makes sense, I thought we wanted to support more markdown overall, happy to go with that instead. |
@SajidAlamQB If we are not planing to add more style to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Related to: #1786
The reminder pop-up notification doesn't parse markdown ` backticks this PR will attempt to add support for it using markdown-it.
Development notes
Checklist
RELEASE.md
file