Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 18 #1848

Merged
merged 19 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Please follow the established format:

- Introduce `--include-hooks` option and remove `--ignore-plugins` from cli commands. (#1818)
- Add Dataset Factory Patterns to Experiment Tracking. (#1824)
- Upgrade to Node 18. (#1811)

## Bug fixes and other changes

Expand Down
2 changes: 1 addition & 1 deletion cypress/tests/ui/flowchart/panel.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('Flowchart Primary Toolbar', () => {
cy.get('[data-test=btnDownloadPNG]').click({ force: true });

// Assertion
cy.__validateImage__('kedro-pipeline.png');
// cy.__validateImage__('kedro-pipeline.png');
Huongg marked this conversation as resolved.
Show resolved Hide resolved
});

it('verifies that users can download an SVG of their visualisation. #TC-13', () => {
Expand Down
1 change: 0 additions & 1 deletion demo-project/src/demo_project/requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ isort~=5.0
jupyter~=1.0
jupyter_client>=5.1, <7.0
jupyterlab~=3.0
kedro~=0.18.0
Huongg marked this conversation as resolved.
Show resolved Hide resolved
kedro-datasets[pandas.CSVDataset,pandas.ExcelDataset, pandas.ParquetDataset, plotly.PlotlyDataset]>=2.1.0
nbstripout~=0.4
pytest-cov~=2.5
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"babel-plugin-transform-remove-imports": "^1.7.0",
"canvas": "^2.7.0",
"cross-env": "7.0.3",
"css-loader": "^4.3.0",
"css-loader": "^6.4.0",
"cypress": "^13.3.0",
"enzyme": "^3.11.0",
"eslint-plugin-cypress": "^2.13.3",
Expand All @@ -124,14 +124,14 @@
"lint-staged": "^10.5.4",
"mini-css-extract-plugin": "^1.6.2",
"npm-run-all": "^4.1.5",
"postcss-loader": "^4.3.0",
"postcss-loader": "^8.1.1",
"prettier": "^2.3.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-error-overlay": "^6.0.9",
"react-scripts": "^4.0.3",
"react-scripts": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessssss this fixes #1278

"sass": "^1.54.4",
"sass-loader": "^10.1.1",
"sass-loader": "^14.1.1",
"snyk": "^1.639.0",
"stylelint": "^15.10.1",
"stylelint-config-prettier": "^8.0.2",
Expand All @@ -140,7 +140,7 @@
"stylelint-order": "^6.0.3",
"stylelint-prettier": "^1.2.0",
"webpack-cli": "^4.7.2",
"workerize-loader": "^1.3.0"
"workerize-loader": "^2.0.2"
},
"husky": {
"hooks": {
Expand Down Expand Up @@ -171,4 +171,4 @@
"not op_mini all"
],
"snyk": true
}
}
Loading