Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kedro-Viz waiting for valid Kedro Project #1871

Merged
merged 22 commits into from
Apr 30, 2024
Merged

Fix Kedro-Viz waiting for valid Kedro Project #1871

merged 22 commits into from
Apr 30, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Apr 22, 2024 •
edited
Loading

Description

Resolves #1761

Development notes

  • Users should be able to run kedro viz run from child dir of a kedro project.
  • Implement util functions _is_project and _find_kedro_project to tackle kedro project not found issue.
  • Update pytests

NOTE: We can implement execution of kedro viz build and kedro viz deploy from child dir in a separate PR as there needs to be a discussion around where to save the local build folder when the user runs from child dir.

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

merelcht and others added 18 commits March 7, 2024 12:51
@merelcht
Try remove bootstrap_project()
9493875 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Try set the package name for spawn process
36c1c32 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@ravi-kumar-pilla
merge main
6c73b4f 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
move configure project before kedro integration
8fc1b87 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
include package name in jupyter and dev run
2fb36ae 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' into experiments-merel
a0805ac
@ravi-kumar-pilla
resolve conflicts
574241b 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix tests and lint
e0446ac 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note
fb41851 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
revert permission change
eba1c30 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' into experiments-merel
0ffc0f8
@ravi-kumar-pilla
fix PR comments
27fc5b6 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
resolve conflicts
1c14b99 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into ex…
eb79b65 
…periments-merel

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into ex…
9884db9 
…periments-merel

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
working draft with parent project search
25db25e 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update error message to be consistent with other viz commands
dede026 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note:
a68fcb7 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Apr 22, 2024
Merged
5 tasks
@ravi-kumar-pilla
merge main
d6d4df1 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note
01eb943 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix Kedro Viz waiting for valid Kedro Project Fix Kedro-Viz waiting for valid Kedro Project Apr 24, 2024
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review April 24, 2024 16:59
@ravi-kumar-pilla ravi-kumar-pilla requested review from noklam, SajidAlamQB and ankatiyar and removed request for astrojuanlu April 24, 2024 17:00
ankatiyar
ankatiyar approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested!

package/kedro_viz/launchers/cli.py Show resolved Hide resolved
@ravi-kumar-pilla
update error message
f16816b 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' into fix/project-not-found
cd42b14
@noklam noklam requested review from noklam and removed request for noklam April 26, 2024 18:03
rashidakanchwala
rashidakanchwala approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM.

@ravi-kumar-pilla ravi-kumar-pilla merged commit 329f13b into main Apr 30, 2024
32 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/project-not-found branch April 30, 2024 20:52
This was referenced May 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankatiyar ankatiyar ankatiyar approved these changes

@noklam noklam noklam left review comments

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@SajidAlamQB SajidAlamQB Awaiting requested review from SajidAlamQB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kedro Viz stays waiting even if no valid project was found
5 participants
@ravi-kumar-pilla @noklam @rashidakanchwala @ankatiyar @merelcht