Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/use kedro sphinx theme #1898

Merged
merged 7 commits into from
May 10, 2024
Merged

Docs/use kedro sphinx theme #1898

merged 7 commits into from
May 10, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented May 9, 2024

Description

Fixes #1882

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huongg added 3 commits May 9, 2024 17:33
@Huongg
remove layout.html
d586c1f 
Signed-off-by: huongg <huongg1409@gmail.com>
@Huongg
refers to kedro-sphinx-theme in setup
eaa19da 
Signed-off-by: huongg <huongg1409@gmail.com>
@Huongg
refers to kedro-sphinx-theme in confy.py
f7966f8 
Signed-off-by: huongg <huongg1409@gmail.com>
@Huongg Huongg marked this pull request as ready for review May 10, 2024 09:03
@Huongg Huongg changed the title [DRAFT] Docs/use kedro sphinx theme Docs/use kedro sphinx theme May 10, 2024
@Huongg Huongg requested review from astrojuanlu and ankatiyar May 10, 2024 09:04
@Huongg
update release note
cccc449 
Signed-off-by: huongg <huongg1409@gmail.com>
@astrojuanlu

This comment was marked as resolved.

Sign in to view
@Huongg
update conf.py in doc/source
c413fd5 
Signed-off-by: huongg <huongg1409@gmail.com>
@astrojuanlu
Copy link
Member

Now that looks OK https://kedro--1898.org.readthedocs.build/projects/kedro-viz/en/1898/ ✔️

@Huongg
update setup.py in demo project
6044671 
Signed-off-by: huongg <huongg1409@gmail.com>
astrojuanlu
astrojuanlu approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pixel perfect to me 👍🏼 Thanks @Huongg!

@Huongg
revert changes for demo-project/docs/source
dba850c 
Signed-off-by: huongg <huongg1409@gmail.com>
ankatiyar
ankatiyar approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Huongg! 🚀

@Huongg Huongg merged commit cb100c7 into main May 10, 2024
37 checks passed
@Huongg Huongg deleted the docs/use-kedro-sphinx-theme branch May 10, 2024 10:55
This was referenced May 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala left review comments

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@ankatiyar ankatiyar ankatiyar approved these changes

@ravi-kumar-pilla ravi-kumar-pilla Awaiting requested review from ravi-kumar-pilla ravi-kumar-pilla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Kedro-viz doc styling by using kedro-sphinx-theme
4 participants
@Huongg @astrojuanlu @rashidakanchwala @ankatiyar