-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken URL when active pipeline name changes on initial load #1914
Conversation
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks @ravi-kumar-pilla
Hi @rashidakanchwala , Could you please remove the CircleCI integration for this repo ? Thank you |
@ravi-kumar-pilla to remove CircleCI Pipeline check you need to sync with main as you branch will have .circleCI config |
I already did - c26b16e |
@ravi-kumar-pilla Rashida recently did it and after that I sync with main and that check is gone. #1894 |
i enabled it now, maybe you need to do another push to re-run the workflows. |
…x/default_pipeline Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
…edro-viz into fix/default_pipeline Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Description
Resolves #1879
Development notes
QA notes
kedro viz run
-> Change the pipeline id in pipeline_registry of your kedro project -> Runkedro viz run
. The URL should point to the new pipeline id.Checklist
RELEASE.md
file