Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URL when active pipeline name changes on initial load #1914

Merged
merged 16 commits into from
May 22, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented May 20, 2024

Description

Resolves #1879

pid_fix

Development notes

  • Remove params check to update activePipeline

QA notes

  • Run kedro viz run -> Change the pipeline id in pipeline_registry of your kedro project -> Run kedro viz run. The URL should point to the new pipeline id.
  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix broken URL when pipeline id changes Fix broken URL when active pipeline name changes on initial load May 20, 2024
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review May 21, 2024 00:12
@ravi-kumar-pilla ravi-kumar-pilla requested review from Huongg and removed request for astrojuanlu May 21, 2024 00:12
Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @ravi-kumar-pilla

@ravi-kumar-pilla
Copy link
Contributor Author

Hi @rashidakanchwala ,

Could you please remove the CircleCI integration for this repo ? Thank you

image

@jitu5
Copy link
Contributor

jitu5 commented May 21, 2024

@ravi-kumar-pilla to remove CircleCI Pipeline check you need to sync with main as you branch will have .circleCI config

@ravi-kumar-pilla
Copy link
Contributor Author

@ravi-kumar-pilla to remove CircleCI Pipeline check you need to sync with main as you branch will have .circleCI config

I already did - c26b16e

@jitu5
Copy link
Contributor

jitu5 commented May 21, 2024

@ravi-kumar-pilla to remove CircleCI Pipeline check you need to sync with main as you branch will have .circleCI config

I already did - c26b16e

@ravi-kumar-pilla Rashida recently did it and after that I sync with main and that check is gone. #1894
Please push something to this branch.

@rashidakanchwala
Copy link
Contributor

i enabled it now, maybe you need to do another push to re-run the workflows.

…x/default_pipeline

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
…edro-viz into fix/default_pipeline

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@rashidakanchwala rashidakanchwala merged commit 3132840 into main May 22, 2024
39 checks passed
@rashidakanchwala rashidakanchwala deleted the fix/default_pipeline branch May 22, 2024 09:24
@Huongg Huongg mentioned this pull request May 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pipeline id which defaults to __default__ pipeline
4 participants