Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed is_preview_disabled to is_preview_enabled #1927

Merged
merged 2 commits into from
May 31, 2024

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented May 23, 2024

Description

Resolves #1894 (comment) & #1870

Changed is_preview_disabled to is_preview_enabled to be consistent with is_all_previews_enabled.

Development notes

  • Rename is_preview_disabled to is_preview_enabled
  • Updated unit test

QA notes

Tested by modifying catalog.yml by adding preview: false

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
@jitu5 jitu5 self-assigned this May 23, 2024
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jitu5

@jitu5 jitu5 merged commit ae76c52 into main May 31, 2024
34 checks passed
@jitu5 jitu5 deleted the feature/rename-is-preview-disabled branch May 31, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants