-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for Kedro-Viz CLI #2044
Docs for Kedro-Viz CLI #2044
Conversation
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better than not having anything ❤️
@rashidakanchwala Did you look at https://sphinx-click.readthedocs.io/en/latest/ ? (Instead of writing the docs manually)
Nicee, technically I didn't write it. ChatGPT did, i just cleaned it up :) -- but I will look at the above. |
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com>
- TCP port that Kedro Viz will listen to. Defaults to `4141`. | ||
|
||
- `--browser / --no-browser` | ||
- Whether to open the Kedro Viz interface in the default browser. The browser will open if the host is `localhost`. Defaults to `True`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this here ? - The browser will open if the host is localhost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i got it from the docs. Maybe we can reword it in cli, and then change it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment. LGTM 👍 ... thank you @rashidakanchwala
Description
Resolves #1705
Development notes
QA notes
Checklist
RELEASE.md
file