-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag
being undefined bug from the backend.
#2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
ravi-kumar-pilla
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the usecase and it looks fixed. Thank you @rashidakanchwala
SajidAlamQB
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rashidakanchwala!
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2106.
Upon investigation based on what user did, I realised that there might be cases where tags might be iteratively added to a node as we iterate through different pipelines. In this case, the node initially had certain tags, but
__default__
pipeline later added additional ones. In our GraphNodes repository, once a graph node is defined, it doesn't get updated with new tags.This PR changes that by allowing nodes to update with any new tags even if they’re already defined. Before the namespace refactor, this issue surprisingly didn’t arise, likely because certain aspects of the refactor introduced unintended behavior that ended up compensating for each other.
See the example to understand better - the code below works fine because
__default__
is defined first, so all nodes belonging to the default pipeline are added to GraphNodeRepository with the correct tags, without any errors:However, if
__default__
is defined last, nodes from ingestion_pipeline are already created. When we try to recreate these nodes with the new tags from__default__
, the tags aren’t added since the nodes already exist.This PR resolves the issue by checking if a node already exists and, if so, assigning it any additional tags:, existing nodes correctly receive any additional tags defined in subsequent pipelines, preventing skipped tag assignments.
QA notes
Checklist
RELEASE.md
file