Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Tracking CleanUp #2278

Open
wants to merge 11 commits into
base: feature_branch/remove-experiment-tracking
Choose a base branch
from

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Feb 22, 2025

Description

I did a final clean-up of Experiment Tracking on Kedro-viz

  • mostly minor stuff here and there
  • removed dataset_factory resolver implementation as it only affected Exp. Tracking
  • also Experiment Tracking last run data was also originally showed in the flowchart metadata panel, so I removed that
  • besides that some plotly references and other stuff.
  • also quite a few of these files are removing experiment tracking data files from demo-project.

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
@rashidakanchwala rashidakanchwala changed the base branch from main to feature_branch/remove-experiment-tracking February 22, 2025 22:51
@@ -68,36 +68,13 @@ def __init__(self):
)
self.dataset_stats = {}

def resolve_dataset_factory_patterns(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was created because Dataset Factories specially didn't work with 'Experiment Tracking', now that we don't have experiment tracking, we don't need this.

cc - @ravi-kumar-pilla

Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
@rashidakanchwala rashidakanchwala marked this pull request as ready for review February 23, 2025 15:11
@rashidakanchwala rashidakanchwala requested review from Huongg and removed request for astrojuanlu February 23, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant