[KED-2165] Remove get_project_context() #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenabalan
requested review from
921kiyo and
DmitriiDeriabinQB
as code owners
lorenabalan
force-pushed
the
fix/remove-get-project-context
branch
from
acfac69 to
0e962a3
Compare
DmitriiDeriabinQB
approved these changes
Dec 7, 2020
Comment on lines
+285
to
+287
| dataset_to_layer = {} | ||
| for layer, dataset_names in _CATALOG.layers.items(): | ||
| dataset_to_layer.update({dataset_name: layer for dataset_name in dataset_names}) |
There was a problem hiding this comment.
🤔 ?
Suggested change
| dataset_to_layer = {} | |
| for layer, dataset_names in _CATALOG.layers.items(): | |
| dataset_to_layer.update({dataset_name: layer for dataset_name in dataset_names}) | |
| dataset_to_layer = { | |
| dataset_name: layer | |
| for layer, dataset_names in _CATALOG.layers.items() | |
| for dataset_name in dataset_names | |
| } |
There was a problem hiding this comment.
I find double for-loops in list comprehensions quite hard to read so I prefer to leave it as it was before.
Co-authored-by: Dmitrii Deriabin <44967953+DmitriiDeriabinQB@users.noreply.github.com>
lorenabalan
force-pushed
the
fix/remove-get-project-context
branch
from
7a4c9d6 to
6a482b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_project_contextwas kept for compatibility with Kedro 0.14.*.Now that we no longer support old versions of Kedro (<0.15), we can replace the calls with
load_context()orKedroSession.load_context().get_project_contextwill also be removed in future major release of Kedro.Development notes
DataCatalog.layersis a definite thing from 0.16.x onwards, no need to check for the old way of having thelayerattribute on the dataset class).develop, and changing the__version__to 0.17.0 (as well asproject_versioninpyproject.tomlin a newly generated kedro project).QA notes
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.