Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade reselect from 4.1.0 to 4.1.1 #642

Closed
wants to merge 2 commits into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to upgrade reselect from 4.1.0 to 4.1.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released a month ago, on 2021-10-26.
Release notes
Package name: reselect
  • 4.1.1 - 2021-10-26

    This releases fixes several TS issues and one runtime issue that were reported with the release of 4.1.0.

    Changelog

    TypeScript Fixes

    All these reported issues should now be fixed:

    • createSelector calls with 12 or more input selectors were causing TS to fail with a "Type instantiation is excessively deep" error. After this update, createSelector should now support up to 29 input selectors before TS has type issues. (and if you've got more than 29 input selectors.... what are you doing? :) )
    • Passing multiple input selectors with mismatched argument types should have been failing to compile, but was being silently accepted (ie (a: number) => 42, (b: string) => 123)
    • The OutputParametricSelector type, which is re-exported by Redux Toolkit, was inadvertently left out of the list of Reselect type exports during the rewrite and caused RTK builds to fail
    • Input selectors that were typed to return SomeType | undefined were causing the entire selector to be typed as possibly returning undefined

    Caching Undefined Values

    The previous internal cache logic had a couple of if (foundValue !== undefined) checks inside, but that broke cases where a selector intentionally wanted to return undefined as the actual result.

    The cache logic has been updated to use an internal sentinel value as the NOT_FOUND result instead, allowing undefined to be correctly cached and returned.

    What's Changed

    • Split out optional last argument (memoizeOptions) into it's own overload by @ eXamadeus in #530
    • increase subselector number by @ phryneas in #528
    • build intersection type instead of union type in GetStateFromSelectors by @ phryneas in #529
    • Update cache to support storing a value of undefined by @ markerikson in #532

    New Contributors

    Full Changelog: v4.1.0...v4.1.1

  • 4.1.0 - 2021-10-26
    Read more
from reselect GitHub release notes
Commit messages
Package name: reselect

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@limdauto
Copy link
Collaborator

Closing so it will be reopened later with the updated lock file.

@limdauto limdauto closed this Nov 23, 2021
@limdauto limdauto deleted the snyk-upgrade-b20c1403f186e1435ba41228c2bae1f5 branch November 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants