Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump watchgod Python package #791

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

tynandebold
Copy link
Member

Description

I was noticing some errors on CircleCI and, with thanks to help from @AntonyMilneQB, we deduced the watchgod package needed an update.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Tynan DeBold <thdebold@gmail.com>
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Worth noting:

  • watchgod 0.8 added support for Python 3.10. At some point we should make kedro-viz support Python 3.9+ (currently it's just up to 3.8, not sure whether there's a reason for that or we just haven't tried out higher version yet).
  • watchgod is changing name to watchfiles: The plan for watchfiles, née watchgod samuelcolvin/watchfiles#102. Since it's a dependency of uvicorn, probably best to see how they handle this in future (and maybe even remove our explicit watchgod dependency in favour of just relying on uvicorn's dependencies)

Copy link
Contributor

@studioswong studioswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@studioswong
Copy link
Contributor

  • watchgod 0.8 added support for Python 3.10. At some point we should make kedro-viz support Python 3.9+ (currently it's just up to 3.8, not sure whether there's a reason for that or we just haven't tried out higher version yet).

Good point - I don't see anything stopping us from supporting Python 3.9+, we can definitely look into bumping our python environment up in the setup_python_env and the release_to_pypi steps in our CI files to see if things still work

@tynandebold tynandebold merged commit 39524c0 into main Mar 23, 2022
@tynandebold tynandebold deleted the chore/bump-watchgod-package branch March 23, 2022 16:15
@limdauto
Copy link
Collaborator

The 3.8 pin was only to match Kedro. Don't think we have re-assessed since Kedro moved to 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants