Skip to content

Commit

Permalink
Add timeout for e2e process waiting
Browse files Browse the repository at this point in the history
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
  • Loading branch information
astrojuanlu committed Jun 28, 2023
1 parent 44c8ea6 commit 06d7a1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion features/jupyter.feature
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ Feature: Jupyter targets in new project
Given I have added a test jupyter notebook
When I execute the test jupyter notebook and save changes
And I execute the kedro jupyter command "convert --all"
And Wait until the process is finished
And Wait until the process is finished for up to "120" seconds
Then I should get a successful exit code
And Code cell with node tag should be converted into kedro node
6 changes: 3 additions & 3 deletions features/steps/cli_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,10 @@ def wait_for_notebook_to_run(context, timeout):
raise TimeoutError("Failed to run Jupyter server in time")


@when("Wait until the process is finished")
def wait(context):
@when('Wait until the process is finished for up to "{timeout:d}" seconds')
def wait(context, timeout):
"""Wait for child process to terminate."""
context.result.wait()
context.result.wait(timeout)


@when("I execute the test jupyter notebook and save changes")
Expand Down

0 comments on commit 06d7a1d

Please sign in to comment.