Skip to content

Commit

Permalink
Address comments on PR
Browse files Browse the repository at this point in the history
  • Loading branch information
merelcht committed Nov 29, 2021
1 parent 0b848bc commit 4c6a7b9
Showing 1 changed file with 13 additions and 16 deletions.
29 changes: 13 additions & 16 deletions tests/framework/project/test_settings.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,15 @@
import sys
import textwrap
from unittest import mock

import pytest

from kedro.framework.context.context import KedroContext
from kedro.framework.project import configure_project, settings
from kedro.framework.session.store import BaseSessionStore

MOCK_CONTEXT_CLASS = mock.patch(
"kedro.framework.context.context.KedroContext", autospec=True
)


def test_settings_without_configure_project_show_default_values():
assert settings.CONF_SOURCE == "conf"
assert settings.CONTEXT_CLASS is KedroContext
assert settings.SESSION_STORE_CLASS is BaseSessionStore
assert settings.SESSION_STORE_ARGS == {}
assert len(settings.DISABLE_HOOKS_FOR_PLUGINS) == 0
class MyContext(KedroContext):
pass


@pytest.fixture
Expand All @@ -28,9 +19,9 @@ def mock_package_name_with_settings_file(tmpdir):
settings_file_path.write(
textwrap.dedent(
f"""
from {__name__} import MOCK_CONTEXT_CLASS
from {__name__} import MyContext
CONF_SOURCE = "test_conf"
CONTEXT_CLASS = MOCK_CONTEXT_CLASS
CONTEXT_CLASS = MyContext
"""
)
)
Expand All @@ -43,11 +34,17 @@ def mock_package_name_with_settings_file(tmpdir):
settings.set(key, value)


def test_settings_without_configure_project_show_default_values():
assert settings.CONF_SOURCE == "conf"
assert settings.CONTEXT_CLASS is KedroContext
assert settings.SESSION_STORE_CLASS is BaseSessionStore
assert settings.SESSION_STORE_ARGS == {}
assert len(settings.DISABLE_HOOKS_FOR_PLUGINS) == 0


def test_settings_after_configuring_project_shows_updated_values(
mocker,
mock_package_name_with_settings_file,
):
mocker.patch("kedro.framework.project.issubclass")
configure_project(mock_package_name_with_settings_file)
assert settings.CONF_SOURCE == "test_conf"
assert settings.CONTEXT_CLASS is MOCK_CONTEXT_CLASS
assert settings.CONTEXT_CLASS is MyContext

0 comments on commit 4c6a7b9

Please sign in to comment.