-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent arguments between kedro run
CLI and the --config
yaml and provide examples in documentation
#1485
Labels
Issue: Feature Request
New feature or improvement to existing feature
Stage: Technical Design 🎨
Ticket needs to undergo technical design before implementation
Comments
noklam
added
the
Issue: Feature Request
New feature or improvement to existing feature
label
Apr 26, 2022
merelcht
added
the
Stage: Technical Design 🎨
Ticket needs to undergo technical design before implementation
label
May 4, 2022
5 tasks
5 tasks
This was linked incorrectly to the wrong PR and shouldn't be closed |
I would add |
This was referenced Aug 17, 2022
We discussed this task in the Technical Design session and decided on the following:
These issues are the follow up actions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue: Feature Request
New feature or improvement to existing feature
Stage: Technical Design 🎨
Ticket needs to undergo technical design before implementation
Description
Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
https://discord.com/channels/778216384475693066/846330075535769601/968467444131848204
Currently, there are 2 ways to provide argument to
kedro run
CLI.kedro run --from-nodes=some_node
--config
argument and define the arguments in a YAML file.kedro run --config=config.yml
The inconsistent API and the lack of examples in documentation could confuse user.
Few proposed changes:
YAML
file in documentationCurrently for
params
it can be defined as a dict, but it will not accept a list for arguments but it has to be a string with commafrom_nodes: xxxx,yyyy,zzzz
. (Not YAML native syntax)load_versions
in the YAML file will be defined as a list ofDATASET_NAME:VERSION
.https://discord.com/channels/778216384475693066/846330075535769601/968467444131848204
run
function, optionally print out what's the argument it has parsed. Currently, if we provide an invalid argument it will still run but doesn't do anything, it is hard to debug, especially the CLI argument can override theYAML
config.Context
Why is this change important to you? How would you use it? How can it benefit other users?
A consistent API will make users' life easier and there is no strong reason why we want 2 different API.
Possible Implementation
(Optional) Suggest an idea for implementing the addition or change.
run
function should be doable, I expect it will be a small change that parsePossible Alternatives
(Optional) Describe any alternative solutions or features you've considered.
The text was updated successfully, but these errors were encountered: