-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate arguments in conf file when passed to CLI #1793
Comments
Adding some more context here:
|
On the specific note w.r.t. hyphens/underscores, I just came across https://jwodder.github.io/kbits/posts/click-config/, which says:
cfg.optionxform = lambda s: s.replace('-', '_') |
conf
arguments passed to CLI
Completed in #3285 |
Description
When using
kedro run --config
no errors are thrown if the arguments in the provided run config file are wrong, e.g.doesn't result in an error, but if you run
kedro run --from_nodes bla
(this should bekedro run --from-nodes
) it will say:Error: No such option: --from_nodes (Possible options: --from-nodes, --nodes, --to-nodes)
Context
#1485
Task
Validate the provided arguments are the expected arguments from the run function, optionally print out what's the argument it has parsed. Currently, if we provide an invalid argument it will still run but doesn't do anything, it is hard to debug, especially the CLI argument can override the YAML config. Some investigation needs to be done to check how feasible this is and what the current behaviour is (e.g. will it throw an error if you misspell a node in
--from-nodes my_node1
or is it ignored?) to make sure it's consistent.The text was updated successfully, but these errors were encountered: