Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution doc and PR template to make it clear to make dataset changes in kedro-datasets #1497

Closed
Tracked by #1457
merelcht opened this issue May 4, 2022 · 3 comments · Fixed by #1991
Closed
Tracked by #1457
Assignees

Comments

@merelcht
Copy link
Member

merelcht commented May 4, 2022

As a team we should never work in kedro.extras.datasets anymore but do all changes in kedro-datasets. On top of that, we should make sure this is clear to open source contributors by adding it to the contribution guide, and at the top of every dataset class and also in the PR template (link to kedro-datasets).

@merelcht merelcht changed the title Update contribution doc and PR template to make it clear to never work on anything in <code class="notranslate">kedro.extras.datasets anymore and only fix issues in <code class="notranslate">kedro-datasets Update contribution doc and PR template to make it clear to never work on anything in kedro.extras.datasets anymore and only fix issues in kedro-datasets May 4, 2022
@merelcht merelcht changed the title Update contribution doc and PR template to make it clear to never work on anything in kedro.extras.datasets anymore and only fix issues in kedro-datasets Update contribution doc and PR template to make it clear make dataset changes in kedro-datasets May 4, 2022
@merelcht merelcht added this to the kedro-datasets milestone May 4, 2022
@merelcht merelcht changed the title Update contribution doc and PR template to make it clear make dataset changes in kedro-datasets Update contribution doc and PR template to make it clear to make dataset changes in kedro-datasets Jun 13, 2022
@merelcht merelcht moved this to To Do in Kedro Framework Oct 24, 2022
@deepyaman
Copy link
Member

@MerelTheisenQB Should this be done immediately, or once kedro-datasets is actually being used by kedro core?

@merelcht
Copy link
Member Author

We can already update the docs and template. This will then be released in 0.18.4 together with #1494

@noklam
Copy link
Contributor

noklam commented Oct 31, 2022

This creates some pain when we sync the diff between extras and kedro-datasets, the diff is gonna be larger. But I guess there's no way around it, we have to review every dataset before we release the kedro-datasets.

Repository owner moved this from In Review to Done in Kedro Framework Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants