Update contribution guidelines documentation for kedro-datasets #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
commented
Oct 31, 2022
noklam
reviewed
Oct 31, 2022
docs/source/extend_kedro/plugins.md
Outdated
| @@ -198,6 +198,8 @@ When you are ready to submit your code: | |||
| - [Kedro-Docker](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-docker), a tool for packaging and shipping Kedro projects within containers | |||
| - [Kedro-Airflow](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-airflow), a tool for converting your Kedro project into an Airflow project | |||
| - [Kedro-Viz](https://github.com/kedro-org/kedro-viz), a tool for visualising your Kedro pipelines | |||
| - [Kedro-Datasets](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-datasets), a collection of all of Kedro's data connectors. These data | |||
| connectors are implementations of the `AbstractDataSet` | |||
There was a problem hiding this comment.
I suggest we put Kedro-Datasets at the top.
There was a problem hiding this comment.
Moved it to the top in b7b82b5
There was a problem hiding this comment.
(Warning: purely pedantic) The order does look a little arbitrary - I'd usually vouch for alphabetical order but it's tougher here to decide priority, maybe datasets followed by airflow and then docker and viz?
ankatiyar
changed the title
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
AhdraMeraliQB
approved these changes
Nov 2, 2022
stichbury
reviewed
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankita Katiyar ankitakatiyar2401@gmail.com
Description
kedro-datasets#1497Update contribution guideline documentation to make it clear to contributors that all the changes should be made in
kedro-datasetsDevelopment notes
kedro.extras.datasetskedro-datasetto list of supported plugins in Kedro pluginsChecklist
RELEASE.mdfile