Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide OmegaConf syntax as option for --params #1907

Closed
merelcht opened this issue Oct 6, 2022 · 1 comment · Fixed by #2120
Closed

Provide OmegaConf syntax as option for --params #1907

merelcht opened this issue Oct 6, 2022 · 1 comment · Fixed by #2120
Assignees

Comments

@merelcht
Copy link
Member

merelcht commented Oct 6, 2022

Description

Provide OmegaConf syntax as second option for CLI --params. Still have Kedro syntax as default + deprecation warning and then replace in 0.19.0.

Context

Currently, Kedro has its own custom syntax and logic for passing parameters in the CLI. We can simplify this by leveraging OmegaConf, which we're also going to use in the configloaders instead of anyconf: #1868

Possible Implementation

Option 1:
image (17)

Option 2:
Add a new boolean flag to support OmegaConf syntax: --new-style
kedro run --new-style --params ...

@merelcht merelcht added this to the Configuration overhaul milestone Oct 6, 2022
@szczeles
Copy link
Contributor

That's a fantastic idea! In kedro-kubeflow and kedro-vertexai we struggled to pass inline parameters of complex types (list and dicts). It looks like OmegaConf.from_dotlist/from_cli can handle both nicely, no need to pre-create config.yaml before the run anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants