-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Kedro, plugin, and test requirements in a single pip install
command
#2588
Comments
I agree this needs fixing. This can be achieved by moving the contents of |
Yeah, the CI adjustments and shuffling of requirements shouldn't be bad at all (and generally beneficial, as you say); the bigger problem is that our requirements aren't actually compatible if installed together, and this needs to be resolved. 😿 |
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
In progress in gh-2597 |
This comment was marked as outdated.
This comment was marked as outdated.
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
* Empty Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Avoid adding problematic lines to requirements.txt kedro is preinstalled in the behave environment, so this should not be needed. In exchange, requirements.txt files can always be read by setuptools automatic parsing. See McK-Private/private-kedro#352 (comment) for motivation of the original logic. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Consolidate all requirements Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix dependencies Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Ignore import order in pylint in favour of isort Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Do not replace kedro plugins in e2e tests Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix dependabot config Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add release notes Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
* Empty Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Avoid adding problematic lines to requirements.txt kedro is preinstalled in the behave environment, so this should not be needed. In exchange, requirements.txt files can always be read by setuptools automatic parsing. See McK-Private/private-kedro#352 (comment) for motivation of the original logic. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Consolidate all requirements Fix gh-2588. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix dependencies Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Ignore import order in pylint in favour of isort Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Do not replace kedro plugins in e2e tests Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix dependabot config Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add release notes Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
I think this is a critical problem that needs resolving.
What this means is that, in reality, we don't have resolvable requirements, and we're only able to get to a resolvable state by overwriting some of the previously-installed requirements. Some of the stuff installed in the
pip install -r test_requirements.txt
are not actually going to be compatible with Kedro onmain
, it seems.Originally posted by @deepyaman in kedro-org/kedro-plugins#155 (comment)
The text was updated successfully, but these errors were encountered: