Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Kedro, plugin, and test requirements in a single pip install command #2588

Closed
deepyaman opened this issue May 17, 2023 · 4 comments · Fixed by #2597
Closed

Install Kedro, plugin, and test requirements in a single pip install command #2588

deepyaman opened this issue May 17, 2023 · 4 comments · Fixed by #2597
Assignees

Comments

@deepyaman
Copy link
Member

I think this is a critical problem that needs resolving.

What this means is that, in reality, we don't have resolvable requirements, and we're only able to get to a resolvable state by overwriting some of the previously-installed requirements. Some of the stuff installed in the pip install -r test_requirements.txt are not actually going to be compatible with Kedro on main, it seems.

Originally posted by @deepyaman in kedro-org/kedro-plugins#155 (comment)

@astrojuanlu
Copy link
Member

I agree this needs fixing.

This can be achieved by moving the contents of test_requirements.txt to the optional-dependencies subtable of pyproject.toml, which requires moving the contents of dependency/requirements.txt to the same file. This will require slight adjustments on our CI, but it's for the greater good.

@deepyaman
Copy link
Member Author

I agree this needs fixing.

This can be achieved by moving the contents of test_requirements.txt to the optional-dependencies subtable of pyproject.toml, which requires moving the contents of dependency/requirements.txt to the same file. This will require slight adjustments on our CI, but it's for the greater good.

Yeah, the CI adjustments and shuffling of requirements shouldn't be bad at all (and generally beneficial, as you say); the bigger problem is that our requirements aren't actually compatible if installed together, and this needs to be resolved. 😿

astrojuanlu added a commit that referenced this issue May 22, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu self-assigned this May 22, 2023
@astrojuanlu
Copy link
Member

In progress in gh-2597

@astrojuanlu

This comment was marked as outdated.

astrojuanlu added a commit that referenced this issue Jul 10, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 10, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 11, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@merelcht merelcht moved this to To Do in Kedro Framework Jul 11, 2023
@astrojuanlu astrojuanlu moved this from To Do to In Review in Kedro Framework Jul 11, 2023
astrojuanlu added a commit that referenced this issue Jul 12, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 12, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 12, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 14, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 14, 2023
Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Jul 18, 2023
* Empty

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Avoid adding problematic lines to requirements.txt

kedro is preinstalled in the behave environment,
so this should not be needed.
In exchange, requirements.txt files can always be read
by setuptools automatic parsing.

See McK-Private/private-kedro#352 (comment)
for motivation of the original logic.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Consolidate all requirements

Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix dependencies

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Ignore import order in pylint in favour of isort

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Do not replace kedro plugins in e2e tests

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix dependabot config

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jul 18, 2023
noklam pushed a commit that referenced this issue Jul 24, 2023
* Empty

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Avoid adding problematic lines to requirements.txt

kedro is preinstalled in the behave environment,
so this should not be needed.
In exchange, requirements.txt files can always be read
by setuptools automatic parsing.

See McK-Private/private-kedro#352 (comment)
for motivation of the original logic.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Consolidate all requirements

Fix gh-2588.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix dependencies

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Ignore import order in pylint in favour of isort

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Do not replace kedro plugins in e2e tests

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix dependabot config

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants