Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kedro ipython tests #3232

Open
ankatiyar opened this issue Oct 26, 2023 · 0 comments
Open

Improve kedro ipython tests #3232

ankatiyar opened this issue Oct 26, 2023 · 0 comments
Labels
Component: Testing Issue/PR that addresses tests Issue: Feature Request New feature or improvement to existing feature
Milestone
Tech debt

Comments

@ankatiyar
Copy link
Contributor

Description

I recently came across a bug with %reload_kedro which wasn't caught by tests because we use a MockKedroContext there. There's a lot of mocking in the ipython tests (probably other places too). This issue is to improve the ipython tests and make them more robust with less mocking.

Context

See #3231 (quick fix for the bug mentioned above)
@ankatiyar ankatiyar added Issue: Feature Request New feature or improvement to existing feature Component: Testing Issue/PR that addresses tests labels Oct 26, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@merelcht merelcht added this to the Tech debt milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Testing Issue/PR that addresses tests Issue: Feature Request New feature or improvement to existing feature
Projects
Kedro Framework
Status: No status
Milestone
Tech debt
Development

No branches or pull requests
2 participants
@merelcht @ankatiyar