Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %reload_kedro line magic #3231

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix %reload_kedro line magic #3231

merged 3 commits into from
Oct 30, 2023

Conversation

ankatiyar
Copy link
Contributor

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

I noticed that %reload_kedro wasn't working on develop because _project_path attribute from KedroContext has been removed/ renamed to project_path.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar requested a review from noklam October 26, 2023 09:20
@ankatiyar ankatiyar marked this pull request as draft October 26, 2023 09:22
@ankatiyar ankatiyar marked this pull request as ready for review October 26, 2023 09:27
@ankatiyar
Copy link
Contributor Author

Need to fix tests for this, wasn't caught because we use a Mocked Kedro Context in the tests 😅

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to improve the test?

@ankatiyar
Copy link
Contributor Author

ankatiyar commented Oct 26, 2023

Is there a way to improve the test?

@noklam
I'll create an issue for it, and try to do it in a separate PR.

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
@ankatiyar ankatiyar enabled auto-merge (squash) October 30, 2023 09:56
@ankatiyar ankatiyar merged commit 67e768f into develop Oct 30, 2023
47 of 52 checks passed
@ankatiyar ankatiyar deleted the fix_reload_kedro branch October 30, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants