-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix %reload_kedro
line magic
#3231
Conversation
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Need to fix tests for this, wasn't caught because we use a Mocked Kedro Context in the tests 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to improve the test?
@noklam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Description
I noticed that
%reload_kedro
wasn't working ondevelop
because_project_path
attribute fromKedroContext
has been removed/ renamed toproject_path
.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file