-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Command 'kedro catalog resolve' fails on dataset factories that use PartitionedDataset #3560
Labels
Community
Issue/PR opened by the open-source community
Issue: Bug Report 🐞
Bug that needs to be fixed
Comments
Thanks for the detailed bug report @MosaicMan ! |
Thank you for the awesome videos man. |
MosaicMan
added a commit
to MosaicMan/kedro
that referenced
this issue
Jan 31, 2024
- Remove filepath check from `resolve_patterns` method. - Eliminate the associated `_trim_filepath` function. - Update release notes. These changes address redundant validations that were causing kedro-org#3560. Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com>
ankatiyar
added a commit
that referenced
this issue
Feb 2, 2024
* Adding a list of "path" keys to check dataset config against. Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com> * Clean up `catalog resolve` CLI command to remove unnecessary checks. - Remove filepath check from `resolve_patterns` method. - Eliminate the associated `_trim_filepath` function. - Update release notes. These changes address redundant validations that were causing #3560. Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com> * Update release notes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Closed in #3561! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Issue/PR opened by the open-source community
Issue: Bug Report 🐞
Bug that needs to be fixed
Description
Running the cli command 'kedro catalog resolve' fails.
Context
The error occurs when trying to use a dataset factory pattern with a PartitionedDataset. It appears that the resolve_patterns method of the kedro.framework.cli.catalog module assumes that every dataset will have a 'filepath' property explicitly defined. That is not true for partitioned datasets.
Steps to Reproduce
Expected Result
The different variations produced by the dataset factory should be displayed on screen:
Actual Result
The command throws an exception:
Your Environment
pip show kedro
orkedro -V
): 0.19.2python -V
): 3.11.7The text was updated successfully, but these errors were encountered: