Create a new dataset allowing querying a Google Bigquery table with a custom SQL statement #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great @simonpicard ! We'll review properly in the week. Thanks for contributing! |
datajoely
requested review from
SajidAlamQB,
lorenabalan and
merelcht
and removed request for
idanov and
yetudada
merelcht
approved these changes
Nov 16, 2021
lorenabalan
approved these changes
Nov 17, 2021
Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
|
Thanks for the review, team!
@lorenabalan I updated the codebase according to your comments, please let me know if you notice something else to update. |
lorenabalan
reviewed
Nov 23, 2021
There was a problem hiding this comment.
Excellent thank you for following up @simonpicard ! Left just a couple of minor docstrings comments, otherwise LGTM. Will merge this today.
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
|
I'll take over this one and get it merged, not sure why CI checks are not showing. |
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new dataset called
GBQQueryDatasetwhich allows querying a Google Bigquery table with a custom SQL statement, either by providing a direct SQL str as parameter for the dataset or using a path to a file containing the query.Linked to #1032
Development notes
GBQQueryDatasetinkedro/extras/datasets/pandas/gbq_dataset.pyGBQTableDatasetandSQLQueryDatasetas inspirationGBQQueryDatasetin the__init__of modulekedro/extras/datasets/pandasGBQQueryDatasetindocs/source/15_api_docs/kedro.extras.datasets.rstfor auto doc generationChecklist
RELEASE.mdfileNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.