-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2865] Make sql datasets use a singleton pattern for connection #1163
Conversation
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
de3e7ae
to
2af5c5f
Compare
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
1b8b917
to
d71ba14
Compare
Really nice work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments for now - I'm going to read through that GitHub issue and ponder a bit more but basically I think looks great 💯 ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite nice, it needs some refactoring of the tests (as in your own comments suggest) and maybe look into create the class attribute similarly to the default arguments, but overall I think we'll be ready to merge this soon. Hopefully it makes it harder for people to run out of connections when having many SQL-based datasets in their pipelines.
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
fc20b4f
to
a19d3fd
Compare
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
3e3c81c
to
372cf29
Compare
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot! Very elegant solution 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work, especially with the testing! ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
…edro-org#1163) Signed-off-by: lorenabalan <lorena.balan@quantumblack.com> Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Signed-off-by: lorenabalan lorena.balan@quantumblack.com
Description
Part of the story about Making Remove Datasets Use a Singleton Pattern. Splitting it into 2 PRs, one for SQL datasets, one for Spark dataset(s).
Development notes
Checklist
RELEASE.md
file