Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up version to 0.18.0 #1399

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Bump up version to 0.18.0 #1399

merged 2 commits into from
Mar 31, 2022

Conversation

lorenabalan
Copy link
Contributor

@lorenabalan lorenabalan commented Mar 31, 2022 •
edited
Loading

Signed-off-by: lorenabalan lorena.balan@quantumblack.com

Description

Development notes

Expected failures:

  • e2e tests due to kedro-telemetry requirement in project reqs (will be fixed on we release the plugin)
  • windows x py3.10 (pip-compile & unit tests) - ignoring until Fiona released
  • unit tests 3.7 & 3.9 - moto / s3fs / weird testing issues; ignoring until release is complete as it's only affecting our test setup (to raise ticket to address this issue)

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Bump up version to 0.18.0
8f44bef 
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
@lorenabalan lorenabalan self-assigned this Mar 31, 2022
merelcht
merelcht approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets-release-this

AhdraMeraliQB
AhdraMeraliQB approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

noklam
noklam approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

SajidAlamQB
SajidAlamQB approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meme release

🎉💥

yetudada
yetudada approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@yetudada yetudada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just so proud of you all! Well done on this!

6avkr7

Just do publish_kedro
b319d41 
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
lorenabalan
lorenabalan commented Mar 31, 2022
View reviewed changes
.circleci/continue_config.yml
- publish_kedro:
requires:
- build_kedro
- publish_kedro
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI had to do this given we have now failing 3.7 and 3.8 builds, and this is a quick shortcircuit to unblock the release rather than scatter a bunch of skip statements.

@lorenabalan lorenabalan merged commit 35e4ac5 into main Mar 31, 2022
@lorenabalan lorenabalan deleted the release/0.18.0 branch March 31, 2022 16:02
@noklam noklam mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@merelcht merelcht merelcht approved these changes

@yetudada yetudada yetudada approved these changes

@noklam noklam noklam approved these changes

@idanov idanov Awaiting requested review from idanov

@antonymilne antonymilne Awaiting requested review from antonymilne

Assignees

@lorenabalan lorenabalan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lorenabalan @noklam @yetudada @merelcht @SajidAlamQB @AhdraMeraliQB