-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api dataset load args #1445
Feature/api dataset load args #1445
Conversation
Signed-off-by: lucas.jamar <lucas.jamar@alpiq.com>
I like this! Would you mind adding a unit test? |
Should we move all the other optional arguments like This would make for a more consistent interface and be tidier I think, but interested in hearing what others think. Maybe there's a good reason those arguments are more important than others passed to |
Signed-off-by: lucas.jamar <lucas.jamar@alpiq.com>
Hi @lucasjamar, are you still interested in completing this PR? Let the team know if you need any help! 🙂 |
@MerelTheisenQB . Im sorry but i really cant find the time to do this properly. I wold be happy if someone can take this over and get the cicd checks to pass. Sorry |
Thanks for the update @lucasjamar and no worries. We'll add it to our backlog and also welcome other contributors to take over if they have capacity. |
Superseded by #1633. Thanks @lucasjamar for your initial work for this! |
Description
In response to #711