Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging documentation #1572

Merged
merged 18 commits into from
May 31, 2022
Merged

Update logging documentation #1572

merged 18 commits into from
May 31, 2022

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented May 24, 2022

Description

Closes #1474. I've written this in parallel with #1569, so there might still be a couple of changes here if things change there. I'm handing over to trusty @SajidAlamQB to update this as required (or in a separate PR if this merges first).

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
antonymilne and others added 7 commits May 25, 2022 15:04
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>

Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>

Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
@antonymilne antonymilne changed the title Update logging.md Update logging documentation May 26, 2022
@antonymilne antonymilne marked this pull request as ready for review May 26, 2022 14:21
docs/source/logging/logging.md Outdated Show resolved Hide resolved
docs/source/logging/logging.md Show resolved Hide resolved
docs/source/logging/logging.md Outdated Show resolved Hide resolved
docs/source/logging/logging.md Outdated Show resolved Hide resolved
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

docs/source/logging/logging.md Outdated Show resolved Hide resolved
antonymilne and others added 5 commits May 26, 2022 21:00
Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@SajidAlamQB SajidAlamQB merged commit c3a20f4 into main May 31, 2022
@SajidAlamQB SajidAlamQB deleted the docs/logging branch May 31, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write documentation on how to make a custom logging.yml in your project
4 participants