-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation on how to visualise Matplotlib plots on Kedro-Viz #1820
Conversation
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
…o into docs/add-matplotlib-plots
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left a few initial comments for now, but some general points:
- this is one example where I think it's worth doing
make build-docs
and checking how it renders, if you didn't already do so - some of our markdown syntax (e.g. hyperlinks, note callouts) is not at all obvious because it's specific to the sphinx build process and sometimes has some weird RST mixed in. It's worth taking a quick look through other
.md
pages to see how we do things - way outside the scope of this, so don't do it here... but the kedro-viz documentation is rapidly outgrowing the Tutorial section of our docs (which originally just covered the spaceflights tutorial really). We need to find a better place for it to live
- love the clear commit message! 💯
|
||
[Plotly](https://plotly.com/python/) is a free and open source Python library that allows you to make interactive, publication-quality graphs. With the Plotly integration on Kedro-Viz, you can output your interactive charts as part of your pipeline visualisation. | ||
Kedro-Viz aims to help users communicate different aspects of their workflow through an interactive flowchart. With the Plotly and Matplotlib integrations, we take one step further in this direction to allow our users to share their data insights effectively while exploring the pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside the scope of your change I know, but I'm personally not a big fan of this paragraph. It feels too vague and marketing-ese to me. Feel free to change it as you please or leave it as it is depending on what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashidakanchwala any thoughts on how to restructure this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, i personally liked this because it excites the user (by technically advertising the feature) but i agree with Antony too.
i will let @yetudada comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't remove it completely - but I would suggest a modification. We describe Kedro-Viz here and also at the top of the page so I would remove the first sentence because we don't need to do it twice.
So it could be something like: "Kedro-Viz supports Plotly and Matplotlib integrations so that you can share your data insights while exploring your pipeline."
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Co-authored-by: Tynan DeBold <thdebold@gmail.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
[Plotly](https://plotly.com/python/) is a free and open source Python library that allows you to make interactive, publication-quality graphs. With the Plotly integration on Kedro-Viz, you can output your interactive charts as part of your pipeline visualisation. | ||
Kedro-Viz aims to help users communicate different aspects of their workflow through an interactive flowchart. With the Plotly and Matplotlib integrations, we take one step further in this direction to allow our users to share their data insights effectively while exploring the pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, i personally liked this because it excites the user (by technically advertising the feature) but i agree with Antony too.
i will let @yetudada comment.
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! ⭐ This is a really clear and easy to follow section.
reporting.dummy_confusion_matrix: | ||
type: matplotlib.MatplotlibWriter | ||
filepath: ${base_location}/08_reporting/dummy_confusion_matrix.png | ||
versioned: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful to add a sentence about why versioned: true
has been set here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Added an explanation in 14d7b98.
Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
…o into docs/add-matplotlib-plots
…edro-org#1820) * Change demo gif to include plots Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add section about plots in experiment tracking view Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add gif of plot comparison Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Replace run list screenshot to include plots Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Replace large demo to include plots Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Separate existing docs into two sections under common subheading Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add description to Matplotlib section Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add Matplotlib node example Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change image name Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add screenshots to example Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint changes Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update images to include all charts Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update docs/source/tutorial/set_up_experiment_tracking.md Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com> * Update docs/source/tutorial/set_up_experiment_tracking.md Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com> * Add suggestions from review Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update docs/source/tutorial/set_up_experiment_tracking.md Co-authored-by: Tynan DeBold <thdebold@gmail.com> * Change heading tense Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Change api link to relative Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Change inline code to code block to follow convention Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Change to Sphinx syntax Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Remove empty lines Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Edit paragraph Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> * Replace randomised node Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix typo and move note Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix linting Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change Kedro-Viz plot visualisations description Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update docs/source/tutorial/visualise_pipeline.md Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com> * Add explanation for versioned flag Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com> Co-authored-by: Tynan DeBold <thdebold@gmail.com> Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com> Signed-off-by: nickolasrm <nickolasrochamachado@gmail.com>
Description
Addresses comments raised in #1704. Kedro-Viz now allows for Matplotlib images to be visualised in the pipeline and metadata panel. This PR adds instructions on how to do so to the documentation.
Development notes
Checklist
RELEASE.md
file