Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show-docs command to Makefile #1959

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Oct 19, 2022

Description

This PR is simply to extend the Kedro makefile to ease docs build/check process by adding a separate "show-docs" command to open the docs in the build location

Development notes

Updated Makefile, tested

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>
@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Oct 19, 2022
@stichbury stichbury requested a review from idanov as a code owner October 19, 2022 10:44
@stichbury stichbury self-assigned this Oct 19, 2022
@stichbury stichbury requested review from merelcht and noklam October 20, 2022 09:47
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@stichbury stichbury merged commit 53b681c into main Oct 21, 2022
@stichbury stichbury deleted the add-show-docs-to-makefile-jos branch October 21, 2022 12:34
amaralbf pushed a commit to amaralbf/kedro that referenced this pull request Oct 22, 2022
Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>

Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>
nickolasrm pushed a commit to ProjetaAi/kedro that referenced this pull request Oct 26, 2022
Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>

Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>
Signed-off-by: nickolasrm <nickolasrochamachado@gmail.com>
mle-els pushed a commit to mle-els/kedro that referenced this pull request Nov 7, 2022
Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>

Signed-off-by: Jo Stichbury <jo.stichbury@quantumblack.com>
Signed-off-by: Minh Le <m.le@elsevier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants