-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate code snippets in datasets documentation - Part 1 #1962
Changes from 38 commits
14afd5d
570c574
981dcfe
c60aef6
07159ff
09b0d46
48ba471
770e3b9
66efe0d
80151f8
6e52ba6
4e3e7b4
d955135
10972d4
57384cc
d6feaac
ce070f5
4f45905
1108411
f0a6f9f
6fa2048
ed06e8d
6de1e01
5de89d5
72d9b96
ed37d70
5d8bd9b
81cf5a4
0803e74
4dfb14e
3ce5dcb
5051e1c
252fb3a
0760011
35d5c28
011b5bb
14fbc85
46d1c30
571866d
9b1a9e4
2ec5c20
84ce260
d0fa348
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,7 @@ def _collect_requirements(requires): | |
"pandas.XMLDataSet": [PANDAS, "lxml~=4.6"], | ||
"pandas.GenericDataSet": [PANDAS], | ||
} | ||
pickle_require = {"pickle.PickleDataSet": ["compress-pickle~=2.1.0"]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original comment said: "# Add "compress_pickle[lz4]" to requirements.txt" Do we need to specify [lz4] for this requirement? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch - this is what the |
||
pillow_require = {"pillow.ImageDataSet": ["Pillow~=9.0"]} | ||
plotly_require = { | ||
"plotly.PlotlyDataSet": [PANDAS, "plotly>=4.8.0, <6.0"], | ||
|
@@ -121,6 +122,7 @@ def _collect_requirements(requires): | |
"holoviews": _collect_requirements(holoviews_require), | ||
"networkx": _collect_requirements(networkx_require), | ||
"pandas": _collect_requirements(pandas_require), | ||
"pickle": _collect_requirements(pickle_require), | ||
"pillow": _collect_requirements(pillow_require), | ||
"plotly": _collect_requirements(plotly_require), | ||
"redis": _collect_requirements(redis_require), | ||
|
@@ -135,6 +137,7 @@ def _collect_requirements(requires): | |
**holoviews_require, | ||
**networkx_require, | ||
**pandas_require, | ||
**pickle_require, | ||
**pillow_require, | ||
**plotly_require, | ||
**spark_require, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON Dataset does not support the
load_args
parameter: https://kedro.readthedocs.io/en/stable/kedro.extras.datasets.json.JSONDataSet.html#kedro.extras.datasets.json.JSONDataSet.__init__There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!