Fix micropkg manifest section in pyproject.toml
#2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
changed the title
micropkg manifest section in pyproject.toml
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
requested review from
AhdraMeraliQB and
SajidAlamQB
and removed request for
idanov and
yetudada
AhdraMeraliQB
approved these changes
Dec 14, 2022
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
This was referenced Dec 14, 2022
|
I am trying to convince my team to adopt Thanks a lot for your great work. |
|
@lamhm This has been included in the recent release, please check them out. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Merel Theisen merel.theisen@quantumblack.com
Description
I found a bug, which makes that you can’t use the micropkg specification in the
pyproject.toml. This line https://github.com/kedro-org/kedro/blob/main/kedro/framework/startup.py#L103 should have been updated tometadata_dict.pop("micropkg", {})when we renamed the cli command fromkedro pipeline packagetokedro micropkg package.Development notes
The existing unit tests didn't catch the bug, because in the setup we don't verify the
pyproject.toml. I've added e2e tests to check the basic packaging commands.Checklist
RELEASE.mdfile